<h3>Block stuff</h3>
<ul>
<li>calling yield when you attach the block to an arg</li>
</ul>
<pre>
def foo(&block)
yield
end
</pre>
<ul>
<li>check for existence of the block when capturing and calling<br />
<pre><br />
def foo(&block)</li>
<li>if block</li>
<li>if !block.nil?</li>
<li>unless block.nil?<br />
end<br />
</pre></li>
</ul>
<h3>Hash stuff</h3>
<pre>
options = {}
options[:a] = 4
options[:b] = 5
options[:c] = 6
</pre>
<h3>Methods</h3>
<ul>
<li>passing instance variables to instance methods</li>
<li>unused private methods (would need to check subclasses as well as instance methods)</li>
<li>Constants as methods (def foo; [:a, :b, :c]; end)</li>
<li>single letter variable names (maybe let them tune the length? meh)</li>
</ul>
<h3>Other</h3>
<ul>
<li>NoMethodException on NilClass</li>
<li><pre>if x && !x.nil? # tautology</pre></li>
<li><pre>if x && x.nil? # contradiction</pre></li>
</ul>
<ul>
<li>Dead code like a return in the middle of a method</li>
</ul>
<ul>
<li>Empty rescue block</li>
</ul>
<ul>
<li>Empty ensure block</li>
</ul>
<ul>
<li>what the heck…any empty block</li>
</ul>
<ul>
<li>Redundant else keyword</li>
</ul>
<ul>
<li>Suggest x = a || b instead of<br />
<pre><br />
if a<br />
x = a<br />
else<br />
x = b<br />
end<br />
</pre></li>
</ul>
<ul>
<li>Redundant requires</li>
</ul>
<ul>
<li>Unused methods/arguments (both for methods or blocks)</li>
</ul>
2009-11-17T00:06:39-08:00
163122
suggested-checks
153976
Suggested Checks
2009-04-04T19:36:10-07:00
14547