TroubleShooting

Issue 3: making version_fu play well with acts_as_deletable: <a href="http://wiki.github.com/ajh/acts_as_soft_deletable">http://wiki.github.com/ajh/acts_as_soft_deletable</a> Issue 2: wrong values for text/blob moved over to versioned table Issue 1: undefined method `version=’ (resolved) <hr /> Issue 3: When both version_fu and acts_as_deletable are operating on a class, deletions followed by restores lose the version history. I am trying to make the version class itself deletable, but not much luck so far. I have modified version_fu.rb as follows: <pre> <code> <ol> <li>Versioned Model const_set(versioned_class_name, Class.new(ActiveRecord::Base)).class_eval do acts_as_soft_deletable # need deleted_statistic_type_versions table</li> <li>find first version before the given version def self.before(version) find :first, :order => ‘version desc’, :conditions => [“#{original_class.versioned_foreign_key} = ? and version < ?”, version.send(original_class.versioned_foreign_key), version.version] end </code> </pre> and this works to the extent that versions are added to the deleted_statistic_type_versions table. However I now need undestroy! to restore the versions as well as the orginal model. To that end I have modified acts_as_soft_deletable as follows:</li> </ol> module InstanceMethods <ol> <li>Restore the model from deleted status. Will destroy the deleted</li> <li>record and recreate the live record. This is done in a transaction</li> <li>and will rollback if problems occur. def undestroy! self.class.transaction do</li> <li>check for any versions and undelete those too deleted_versions = self.class.live_class::Version::Deleted.find_all_by_statistic_type_id(self.id) deleted_versions.each do |deleted| deleted.undestroy! end</li> <li>create instance in version table model = self.class.live_class.new self.attributes.reject{|k,v| k == ’deleted_at’}.keys.each do |key| model.send(“#{key}=”, self.send(key)) end model.save!</li> </ol> self.destroy end true end end and the query to grab all the deleted versions runs fine from the console: self.class.live_class::Version::Deleted.find_all_by_statistic_type_id(self.id) However I get the following error when I try to undestroy from a unit test: <pre> <code> 1) Error: test_versioning(StatisticTypeTest): ArgumentError: StatisticType is not missing constant Version! /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/dependencies.rb:253:in `load_missing_constant' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/dependencies.rb:484:in `const_missing' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/dependencies.rb:486:in `send' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/dependencies.rb:486:in `const_missing' /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting-fresh/vendor/plugins/acts_as_soft_deletable/lib/acts_as_soft_deletable.rb:118:in `undestroy!' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/connection_adapters/abstract/database_statements.rb:66:in `transaction' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:79:in `transaction' /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting-fresh/vendor/plugins/acts_as_soft_deletable/lib/acts_as_soft_deletable.rb:116:in `undestroy!' /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting-fresh/vendor/plugins/acts_as_soft_deletable/lib/acts_as_soft_deletable.rb:120:in `undestroy!' /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting-fresh/vendor/plugins/acts_as_soft_deletable/lib/acts_as_soft_deletable.rb:119:in `each' /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting-fresh/vendor/plugins/acts_as_soft_deletable/lib/acts_as_soft_deletable.rb:119:in `undestroy!' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/connection_adapters/abstract/database_statements.rb:66:in `transaction' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:79:in `transaction' /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting-fresh/vendor/plugins/acts_as_soft_deletable/lib/acts_as_soft_deletable.rb:116:in `undestroy!' test/unit/statistic_type_test.rb:45:in `test_versioning' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/testing/setup_and_teardown.rb:67:in `run' </code> </pre> I’ll also add this to the acts_as_soft_deletable wiki as well. Why github doesn’t have built in forums for projects I have no idea … I’ve now got round this problem by using the following code in acts_as_soft_deletable: module InstanceMethods <ol> <li>Restore the model from deleted status. Will destroy the deleted</li> <li>record and recreate the live record. This is done in a transaction</li> <li>and will rollback if problems occur. def undestroy! self.class.transaction do</li> <li>check for any versions and undelete those too if self.class.live_class.respond_to?(:versioned_class_name) deleted_versions = self.class.live_class::Version::Deleted.find_all_by_statistic_type_id(self.id) deleted_versions.each do |deleted| deleted.undestroy! end end</li> <li>create instance in version table model = self.class.live_class.new self.attributes.reject{|k,v| k == ’deleted_at’}.keys.each do |key| model.send(“#{key}=”, self.send(key)) end model.save!</li> </ol> self.destroy end true end end This if statement “if self.class.live_class.respond_to?(:versioned_class_name)” makes sure that we don’t try and look for versions of versions. Now I have the versions being undeleted, but unfortunately when the live_class is recreated by acts_as_soft_deletable it also fires off version_fu, which adds a new row to the versions table which is now unecessary. Trying to switch that off now … Aha, I think I may have cracked it: module InstanceMethods <ol> <li>Restore the model from deleted status. Will destroy the deleted</li> <li>record and recreate the live record. This is done in a transaction</li> <li>and will rollback if problems occur. def undestroy! self.class.transaction do</li> <li>check for any versions and undelete those too if self.class.live_class.respond_to?(:versioned_class_name) deleted_versions = self.class.live_class::Version::Deleted.find_all_by_statistic_type_id(self.id) deleted_versions.each do |deleted| deleted.undestroy! end end</li> <li>create instance in version table model = self.class.live_class.new self.attributes.reject{|k,v| k == ’deleted_at’}.keys.each do |key| model.send(“#{key}=”, self.send(key)) end model.restoring_from_delete = true if self.class.live_class.respond_to?(:restoring_from_delete) model.save!</li> </ol> self.destroy end true end end on the acts_as_soft_deletable side combined with def create_new_version? if self.restoring_from_delete self.restoring_from_delete = false return false end <ol> <li>Any versioned column changed?</li> <li>don’t create new version if being called from acts_as_soft_deletable self.class.versioned_columns.detect {|a| send “#{a}_changed?”} end</li> </ol> on the version_fu side along with: <pre> <code> cattr_accessor :versioned_class_name, :versioned_foreign_key, :versioned_table_name, :version_column, :versioned_columns, :restoring_from_delete self.versioned_class_name = options[:class_name] || 'Version' self.versioned_foreign_key = options[:foreign_key] || self.to_s.foreign_key self.versioned_table_name = options[:table_name] || "#{table_name_prefix}#{base_class.name.demodulize.underscore}_versions#{table_name_suffix}" self.version_column = options[:version_column] || 'version' self.restoring_from_delete = false </code> </pre> Seems to do the trick. I have some of my own unit-tests but not sure how to integrate across the two projects. Any tips on how to submit code back so that these two great plugins will play nicely together will be very much appreciated. <hr /> Issue 2: the text field in the table created by the following: def self.up create_table :statistic_type_versions do |t| t.integer :statistic_type_id, :statistic_category_id t.string :name, :time_filter, :unit t.text :sql t.timestamps end add_column :statistic_types, :version, :integer, :default=>1 end appears to have the data from the new version rather than the old version in it. The old data appears to be lost. The text/blob field may also just be nil as shown in the example below: <pre> <code> >> type = StatisticType.new => #<StatisticType id: nil, name: "", time_filter: "", unit: "", sql: nil, statistic_category_id: nil, version: 1> >> type.name = 'original_name' => "original_name" >> type.sql = 'original_sql' => "original_sql" >> type.save => true >> type.name => "original_name" >> type.sql => "original_sql" >> type.name = 'new_name' => "new_name" >> type.sql = 'new_sql' => "new_sql" >> type.save => true >> type.name => "new_name" >> type.sql => "new_sql" >> type.id => 5 >> versioned_type = StatisticType::Version.find(:first, :conditions => 'statistic_type_id = 5') => #<StatisticType::Version id: 7, statistic_type_id: 5, statistic_category_id: nil, version: 1, name: "original_name", time_filter: "", unit: "", sql: nil, created_at: "2008-10-31 15:34:15", updated_at: "2008-10-31 15:34:15"> >> versioned_type.name => "original_name" >> versioned_type.sql => nil </code> </pre> Here’s rails log of the SQL commands generated by version_fu in the above example <pre> <code> SQL (0.000213) SET NAMES 'utf8' SQL (0.000118) SET SQL_AUTO_IS_NULL=0 StatisticType::Version Columns (0.002405) SHOW FIELDS FROM `statistic_type_versions` StatisticType Columns (0.001584) SHOW FIELDS FROM `statistic_types` SQL (0.000295) BEGIN StatisticType Create (0.000241) INSERT INTO `statistic_types` (`name`, `statistic_category_id`, `sql`, `unit`, `version`, `time_filter`) VALUES('original_name', NULL, 'original_sql', '', 1, '') StatisticType::Version Load (0.000273) SELECT * FROM `statistic_type_versions` WHERE (`statistic_type_versions`.statistic_type_id = NULL) StatisticType::Version Create (0.000181) INSERT INTO `statistic_type_versions` (`name`, `updated_at`, `statistic_category_id`, `sql`, `unit`, `statistic_type_id`, `version`, `time_filter`, `created_at`) VALUES('original_name', '2008-10-31 16:08:36', NULL, 'original_sql', '', 6, 1, '', '2008-10-31 16:08:36') SQL (0.053981) COMMIT SQL (0.000294) BEGIN StatisticType Update (0.000285) UPDATE `statistic_types` SET `sql` = 'new_sql', `version` = 2, `name` = 'new_name' WHERE `id` = 6 StatisticType::Version Create (0.000196) INSERT INTO `statistic_type_versions` (`name`, `updated_at`, `statistic_category_id`, `sql`, `unit`, `statistic_type_id`, `version`, `time_filter`, `created_at`) VALUES('new_name', '2008-10-31 16:09:25', NULL, 'new_sql', '', 6, 2, '', '2008-10-31 16:09:25') SQL (0.000587) COMMIT StatisticType::Version Load (0.001143) SELECT * FROM `statistic_type_versions` WHERE (statistic_type_id = 6) LIMIT 1 </code> </pre> In my test database it seems like saving causes two rows to be added to the version table, one for the old version and another for the new version (which doesn’t seem wonderfully dry, given some of that information is in the original table), but in my production database there is only ever one row added to the version table after a save … Any ideas what might be causing this problem? Many thanks in advance Response Instead of <pre>StatisticType::Version.find(:first, :conditions => 'statistic_type_id = 5')</pre> try type.versions Follow Up Unfortunately that doesn’t seem to help, e.g. <pre> <code> >> type = StatisticType.find(51) => #<StatisticType id: 51, name: "registered users", time_filter: "RollingDayFilter.new(DayFilter.new(time_point).prev...", unit: "", sql: "\"SELECT COUNT(*) AS total_registered_users\nFROM \#{A...", statistic_category_id: 11, version: 1> >> type.sql = 'new stuff' => "new stuff" >> type.save => true >> type.versions => [#<StatisticType::Version id: 8, statistic_type_id: 51, statistic_category_id: 11, version: 2, name: "registered users", time_filter: "RollingDayFilter.new(DayFilter.new(time_point).prev...", unit: "", sql: "new stuff", created_at: "2008-11-01 02:26:23", updated_at: "2008-11-01 02:26:23">] </code> </pre> Notice how there is only one element in the type.versions array, and it has the sql field set to “new stuff”. The old version has disappeared. Here is the rails log for the above: <pre> <code> StatisticType Load (0.000593) SELECT * FROM `statistic_types` WHERE (`statistic_types`.`id` = 51) SQL (0.000272) BEGIN StatisticType Update (0.000390) UPDATE `statistic_types` SET `sql` = 'new stuff', `version` = 2 WHERE `id` = 51 StatisticType::Version Create (0.000360) INSERT INTO `statistic_type_versions` (`name`, `updated_at`, `statistic_category_id`, `sql`, `unit`, `statistic_type_id`, `version`, `time_filter`, `created_at`) VALUES('registered users', '2008-11-01 02:26:23', 11, 'new stuff', '', 51, 2, 'RollingDayFilter.new(DayFilter.new(time_point).prev.raw_time)', '2008-11-01 02:26:23') SQL (0.001074) COMMIT StatisticType::Version Load (0.000570) SELECT * FROM `statistic_type_versions` WHERE (`statistic_type_versions`.statistic_type_id = 51) </code> </pre> It seems that only one entry is inserted into the versions table, it is version 2 and it has “new stuff” in the sql field, i.e version 1 has been lost … Solution Well it seems that the problem is that version_fu assumes that the model has been created through the version_fu framework, and is assuming that there will already be an entry in the version table for the first version of the model. In my case I added version_fu to an existing legacy table, which is why I ran into this problem. My hacky solution is go through the legacy data and dump copies of first versions into the version table to ensure that things don’t get deleted accidentally. However it does seem a little unDRY to be storing the version 1 in the versions table from the get go. Was there some difficulty that meant that this was much easier than the previous acts_as_versioned system which only dumped something in the versions table after version 2 appeared? <del>-</del>— Issue 1: I’m getting the following error when trying to save a versioned model in Rails 2.1.1: My model class StatisticType < ActiveRecord::Base has_many :statistic_summaries version_fu end >> type = StatisticType.find(1) >> type.name = ‘bob’ => “bob” >> type.save NoMethodError: undefined method `version=’ for #<StatisticType::Version:0x244c3a0> from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/attribute_methods.rb:251:in `method_missing’ from /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting/vendor/plugins/version_fu/lib/version_fu.rb:101:in `instatiate_revision’ from /Users/samueljoseph/Code/eclipse-workspace/iknow_reporting/vendor/plugins/version_fu/lib/version_fu.rb:85:in `check_for_new_version’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:173:in `send’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:173:in `evaluate_method’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:161:in `call’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:93:in `run’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:92:in `each’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:92:in `send’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:92:in `run’ from /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.1.1/lib/active_support/callbacks.rb:272:in `run_callbacks’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/callbacks.rb:298:in `callback’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/callbacks.rb:206:in `create_or_update’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/base.rb:2211:in `save_without_validation’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/validations.rb:911:in `save_without_dirty’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/dirty.rb:75:in `save_without_transactions’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:106:in `save’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/connection_adapters/abstract/database_statements.rb:66:in `transaction’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:79:in `transaction’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:98:in `transaction’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:106:in `save’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:118:in `rollback_active_record_state!’ from /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.1.1/lib/active_record/transactions.rb:106:in `save’ Here’s the migration I used to prepare things (I checked in the database to make sure the changes are there): class AddStatisticTypeVersioning < ActiveRecord::Migration def self.up create_table :statistic_type_versions do |t| t.integer :statistic_type_id, :statistic_category_id t.string :name, :time_filter, :unit t.text :sql t.timestamps end add_column :statistic_types, :version, :integer, :default=>1 end def self.down remove_column :statistic_types, :version drop_table :statistic_type_versions end end Am I making some simple mistake? Many thanks in advance Answer You need a version(int) column in the statistic_type_versions table Response Many thanks – I added that but I still seem to get the same error, i.e. undefined method `version=’ for #<StatisticType::Version:0x244c3a0> which is very odd … is the usage of version_fu close to identical to that of acts_as_versioned? Answer ah, I hadn’t re-created the test database off the new structure – working now … <hr /> 2008-10-21T12:56:16-07:00 70375 troubleshooting

12955

TroubleShooting

2009-03-10T17:30:26-07:00

30216